Add Hostname RPC command #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@balloob and I have been discussing the new Hostname RPC command as an expansion to the Improv standard.
Most IoT devices will be assigned/select a hostname unique to the device that it uses to broadcast mDNS based entries. There is no way with Improv currently to set this and therefore devices must rely on the setup page afterwards to setup the hostname.
However the page they access may actually INCLUDE the hostname so having it be something that gets configured post setup is not ideal.
It would be best if the Improv standard allowed us to get and specify the hostname of the device during the Authorized stage.
That would allow us to render an additional text box on the SSID/password screen containing the current hostname and allowing the user to modify it.
We would call the new "Get hostname" RPC as soon as the initial device connection is made and use that information to render the next page.